feat(datafusion): make PartitionExpr reconstructible - #3001
Open
NoahKusaba wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
PartitionExpr wraps a PartitionValueCalculator, which is a live object with
no serializable form. Once the expression is built, nothing on it says which
partition spec and schema produced it, so a caller holding the expression
cannot rebuild an equivalent one.
Retain both inputs on the expression and expose them:
builds the calculator itself, so the two inputs and the calculator cannot
drift apart.
iceberg spec types, so a distributed engine can serialize them and rebuild
the expression on a worker with try_new.
project_with_partition is unchanged from the outside; it now hands the two
inputs to try_new instead of constructing the calculator first.
Are these changes tested?
The existing project tests cover the refactor itself, as it now constructs through try_new and still pass unchanged.
AI Disclosure