ci: install taplo and cargo-machete from prebuilt binaries#2680
Open
abnobdoss wants to merge 1 commit into
Open
ci: install taplo and cargo-machete from prebuilt binaries#2680abnobdoss wants to merge 1 commit into
abnobdoss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
checkjob's tooling.What changes are included in this PR?
The
checkjob installstaploandcargo-machetefrom source on every run:make check-tomlrunscargo install --locked taplo-cli@0.9.3andmake cargo-macheterunscargo install cargo-machete@0.7.0. Compiling these tools from source costs roughly 2 minutes per run, on each OS in thecheckmatrix.This switches both to prebuilt binaries via
taiki-e/install-action— the same mechanism the repo already uses forcargo-nextest(in thetestsjob) andcargo-public-api(inpublic-api.yml). The action downloads the published release binary instead of compiling it.Concretely, in the
checkjob this adds one install step and points the two checks at the installed binaries:taiki-e/install-actionwithtool: taplo@0.9.3,cargo-machete@0.7.0taplo fmt --checkcargo macheteThe pinned tool versions match what the
Makefileinstalls today (taplo0.9.3,cargo-machete0.7.0), so the checks themselves are unchanged — only the install path differs. TheMakefiletargets are left as-is for local development.Are these changes tested?