refactor(encryption) remove key_metadata from the constructor of an unencrypted manifest writer#2666
Open
xanderbailey wants to merge 3 commits into
Open
Conversation
xanderbailey
commented
Jun 17, 2026
| let builder = ManifestWriterBuilder::new( | ||
| output_file, | ||
| Some(self.snapshot_id), | ||
| self.key_metadata.clone(), |
Contributor
Author
There was a problem hiding this comment.
The metadata here comes from the fast append action which I think is also wrong but I'll remove that in a further follow up PR to keep these refactors targeted.
Contributor
Author
There was a problem hiding this comment.
Ahh metadata becomes dead code on snapshot producer so maybe I will remove here.
blackmwk
approved these changes
Jun 17, 2026
blackmwk
left a comment
blackmwk
left a comment
Contributor
There was a problem hiding this comment.
Thanks @xanderbailey for this pr, just one minor comment.
| @@ -60,7 +60,6 @@ impl ManifestWriterBuilder { | |||
| pub fn new( | |||
Contributor
There was a problem hiding this comment.
We should add comments to explain that this is for creating an unencrypted manifest.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow up for #2628
What changes are included in this PR?
Now that we have two constructors for
ManifestWriterBuilder,newandnew_from_encrypted, it should never be the case that you want to presentkey_metadatato an unencryptedoutput.Are these changes tested?