refactor(writer): Make writer builders non-consuming in build #1889
+24
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
reviewed
Dec 1, 2025
Collaborator
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
Hi @leonzchang , thanks for the contribution! LGTM in general
There are also some clone() usages in writers under partitioning module like this.
Could you help remove them as well in this PR?
| F: FileNameGenerator, | ||
| B: FileWriterBuilder + Sync, | ||
| L: LocationGenerator + Sync, | ||
| F: FileNameGenerator + Sync, |
Collaborator
There was a problem hiding this comment.
I think we should just add supertrait Sync to these traits to enforce it across different implementations
Contributor
There was a problem hiding this comment.
Also we should remove the Clone in trait implementation in builders.
| F: FileNameGenerator, | ||
| B: FileWriterBuilder + Sync, | ||
| L: LocationGenerator + Sync, | ||
| F: FileNameGenerator + Sync, |
CTTY
reviewed
Dec 3, 2025
crates/iceberg/src/writer/mod.rs
Outdated
| //! | ||
| //! #[async_trait::async_trait] | ||
| //! impl<B: IcebergWriterBuilder> IcebergWriterBuilder for LatencyRecordWriterBuilder<B> { | ||
| //! impl<B: IcebergWriterBuilder + Sync> IcebergWriterBuilder for LatencyRecordWriterBuilder<B> { |
Collaborator
There was a problem hiding this comment.
Is there any reason why we don't add Sync as supertrait here?
|
|
||
| /// File writer builder trait. | ||
| pub trait FileWriterBuilder<O = DefaultOutput>: Send + Clone + 'static { | ||
| pub trait FileWriterBuilder<O = DefaultOutput>: Clone + Send + Sync + 'static { |
Contributor
There was a problem hiding this comment.
Why we need to keep this Clone?
|
|
||
| /// `FileNameGeneratorTrait` used to generate file name for data file. The file name can be passed to `LocationGenerator` to generate the location of the file. | ||
| pub trait FileNameGenerator: Clone + Send + 'static { | ||
| pub trait FileNameGenerator: Clone + Send + Sync + 'static { |
|
|
||
| /// `LocationGenerator` used to generate the location of data file. | ||
| pub trait LocationGenerator: Clone + Send + 'static { | ||
| pub trait LocationGenerator: Clone + Send + Sync + 'static { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This change allows users to reuse builder instances without cloning when creating multiple writers with the same configuration.
Modification non-consuming self in build function:
IcebergWriterBuilderRollingFileWriterBuilderFileWriterBuilderAre these changes tested?