Add concurrency safety validation checks#3049
Merged
Fokko merged 3 commits intoapache:mainfrom Feb 20, 2026
Merged
Conversation
…te_no_new_deletes_for_data_file
gabeiglio
force-pushed
the
validation-checks
branch
from
052f6a7 to
32b2428
Compare
geruh
reviewed
Feb 17, 2026
tusharchou
reviewed
Feb 17, 2026
| parent_snapshot: Ending snapshot on the branch being validated | ||
| """ | ||
| # If there is no current state, or no files has been added | ||
| if parent_snapshot is None or table.format_version < 2: |
Contributor
There was a problem hiding this comment.
I've verified this logic locally by mocking a concurrent conflict. The table.format_version < 2 guard correctly prevents unnecessary overhead for V1 tables, and the use of the DeleteFileIndex ensures we are only blocking commits when there is a real overlap in data files (avoiding 'lazy' global locks).
Fokko
reviewed
Feb 18, 2026
Fokko
approved these changes
Feb 19, 2026
Contributor
|
Thanks, @gabeiglio, for fixing this. Let's move this forward. Thanks @tusharchou and @geruh for the review 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1930
Closes #1931
Rationale for this change
Now that we have an implementation of DeleteFileIndex we can move ahead and implement the last two safety concurrency validations mentioned in this #819
Are these changes tested?
Yes
Are there any user-facing changes?
No