Feat cache residual evaluator #2695
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#2147 - Implement ResidualEvaluatorCache with LRU eviction and thread safety - Cache evaluators by partition spec, expression, case sensitivity, and schema - Fix mypy type annotations and add type ignore for cachetools decorator
ForeverAngry
force-pushed
the
feat-cache-residual-evaluator
branch
from
55e53d0 to
0ec381e
Compare
Fokko
reviewed
Nov 14, 2025
Comment on lines
+2084
to
+2086
| cached = _residual_evaluator_cache.get(spec, expr, case_sensitive, schema) | ||
| if cached is not None: | ||
| return cached |
Contributor
There was a problem hiding this comment.
Why not use the build in LRU cache? https://docs.python.org/3/library/functools.html#functools.lru_cache
Contributor
Author
There was a problem hiding this comment.
We certainly can, it would have been much simpler. My main motivation was really about implementing something that was more extensible, readable (so that people dont have to dig to deep to see whats actually happening) that users could have more control over.
Im happy to simplify it. Let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2147
Rationale for this change
For queries, the same combinations of (partition spec, expression, case sensitivity, schema) are evaluated repeatedly, causing unnecessary computational overhead and increased query latency.
Are these changes tested?
Yes, using the existing test cases as they seemed sufficient for the changes.
Are there any user-facing changes?
No.