Skip to content

build: scope warnings-as-error to project targets, not FetchContent subprojects #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yadavay-amzn wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

build: scope warnings-as-error to project targets, not FetchContent subprojects #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ set(CMAKE_CXX_STANDARD 23)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
set(CMAKE_COMPILE_WARNING_AS_ERROR ON)

option(ICEBERG_BUILD_STATIC "Build static library" ON)
option(ICEBERG_BUILD_SHARED "Build shared library" OFF)
option(ICEBERG_BUILD_TESTS "Build tests" ON)
Expand Down
2 changes: 2 additions & 0 deletions cmake_modules/IcebergBuildUtils.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ function(add_iceberg_lib LIB_NAME)

if(BUILD_SHARED)
add_library(${LIB_NAME}_shared SHARED)
set_target_properties(${LIB_NAME}_shared PROPERTIES COMPILE_WARNING_AS_ERROR ON)

if(LIB_DEPS)
target_sources(${LIB_NAME}_shared PRIVATE ${LIB_DEPS})
Expand Down Expand Up @@ -172,6 +173,7 @@ function(add_iceberg_lib LIB_NAME)

if(BUILD_STATIC)
add_library(${LIB_NAME}_static STATIC)
set_target_properties(${LIB_NAME}_static PROPERTIES COMPILE_WARNING_AS_ERROR ON)

if(LIB_DEPS)
target_sources(${LIB_NAME}_static PRIVATE ${LIB_DEPS})
Expand Down
4 changes: 4 additions & 0 deletions cmake_modules/IcebergThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ endmacro()
function(resolve_arrow_dependency)
prepare_fetchcontent()

# Prevent Arrow from injecting -Werror into CMAKE_CXX_FLAGS_DEBUG via
# arrow_add_werror_if_debug(). PRODUCTION level only adds standard warnings.
set(BUILD_WARNING_LEVEL PRODUCTION)

set(ARROW_BUILD_SHARED OFF)
set(ARROW_BUILD_STATIC ON)
# Work around undefined symbol: arrow::ipc::ReadSchema(arrow::io::InputStream*, arrow::ipc::DictionaryMemo*)
Expand Down
2 changes: 0 additions & 2 deletions src/iceberg/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
# specific language governing permissions and limitations
# under the License.

set(CMAKE_COMPILE_WARNING_AS_ERROR FALSE)

set(INSTALL_GTEST
OFF
CACHE BOOL "" FORCE)
Expand Down
Loading