Repository navigation
perf(util): encode Base64 in three-byte blocks - #1045
Open
fallintoplace wants to merge 2 commits into
Open
fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
zhjwpku
approved these changes
Oct 20, 2026
zhjwpku
left a comment
zhjwpku
left a comment
Collaborator
There was a problem hiding this comment.
The refactor looks clean and more understandable to me, thanks for the PR.
| if (remainder == 2) { | ||
| output[out++] = alphabet[(block >> 6) & 0x3F]; | ||
| } | ||
| if (pad) { |
Collaborator
There was a problem hiding this comment.
nit: seems we can delete this condition wrapper since the output_size is exact.
zhjwpku
added
the
ready to merge
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Implementation
Benchmark
-O3: 1 KiB 2.427 → 0.811 µs (3.0x); 16 KiB 37.55 → 13.49 µs (2.8x).