Repository navigation
Conversation
- Add selectable forward and embedded REST executors with forward as default. - Reuse the existing Gremlin workers, serializer, auth context and transactions. - Integrate executor startup, shutdown and supported-topology validation. - Add differential contract tests, usage docs and reproducible benchmarks.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3388 +/- ##
============================================
- Coverage 55.93% 55.90% -0.03%
- Complexity 2277 6784 +4507
============================================
Files 774 779 +5
Lines 68534 69114 +580
Branches 9333 9468 +135
============================================
+ Hits 38334 38641 +307
- Misses 26634 26893 +259
- Partials 3566 3580 +14
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Add opt-in in-process execution for REST
/gremlinto remove its internal HTTP forwarding hop.gremlinserver.rest_execution_modedefaults toforward;embeddeduses this Server's existing Gremlin runtime.Builds on the merged Java 17 (#3261) and TinkerPop 3.8.1 (#3263) upgrades. Design and investigation.
Main Changes
Readiness, new overload controls, authentication-cache consistency and global shutdown redesign remain separate tasks.
Verifying these changes
Draft follow-up: at concurrency 32 with 1,000-result responses, the extended comparison's p95 medians were 77.94 -> 68.50 ms, while p99 medians were 90.71 -> 109.59 ms (forward -> embedded). Investigate the tail behavior at matched offered load; these were closed-loop runs on a shared host. HStore, full TinkerPop suites and real authentication-store integration remain unverified.
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO: required documentation is pending; complete it before merging.Doc - Done: documentation is included here or linked below.Doc - No Need: no user-visible documentation is affected.Documentation: REST Gremlin execution modes, linked from the Server README and shipped configuration.