feat(storage): support separate zstd level for native parquet logs - #19781
Open
cshuo wants to merge 1 commit into
Open
feat(storage): support separate zstd level for native parquet logs#19781cshuo wants to merge 1 commit into
cshuo wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19781 +/- ##
============================================
+ Coverage 78.11% 78.15% +0.03%
- Complexity 33673 33695 +22
============================================
Files 2540 2540
Lines 141413 141441 +28
Branches 17123 17126 +3
============================================
+ Hits 110467 110545 +78
+ Misses 23250 23200 -50
Partials 7696 7696
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Closes #19780.
The global Hadoop
parquet.compression.codec.zstd.levelsetting currently applies to both Parquet base files and native Parquet log files. Native logs favor write latency and may not need the higher compression level selected for base files, but there is no independent native-log setting.Summary and Changelog
hoodie.logfile.parquet.compression.codec.zstd.levelconfiguration with a default value of1.ParquetUtilshelper that applies the native-log level only to native log paths, copying the storage configuration only when the global level is absent or different.HoodieParquetConfigInjectorin Spark, Flink, and Avro/Java Parquet writer factories, preserving the custom injector as the highest-priority extension point.Impact
Users can tune native Parquet log Zstd compression independently from base files. Native logs default to level
1, while base files retain the global Hadoop setting. This adds one optional advanced configuration and does not change Hudi's storage format or public APIs.Risk Level
Low. The override is limited to native log paths, base-file paths retain the original configuration instance, and custom Parquet config injectors still run last. The targeted
TestParquetUtils#testApplyNativeLogZstdCompressionLeveland Flink Parquet writer factory test passed.Documentation Update
The new configuration and its default behavior are documented in
HoodieStorageConfig. No storage-format documentation changes are required.Contributor's checklist