feat(lance): Ensure Spark-SQL works correctly when using lance as base file format#18375
Draft
wombatu-kun wants to merge 1 commit intoapache:masterfrom
Draft
feat(lance): Ensure Spark-SQL works correctly when using lance as base file format#18375wombatu-kun wants to merge 1 commit intoapache:masterfrom
wombatu-kun wants to merge 1 commit intoapache:masterfrom
Conversation
0a1f3c8 to
48b2d92
Compare
…e file format parametrized TestSqlStatement with lance/parquet baseFileFormat fixed TestAvroFileWriterFactory and TestSecondaryIndexPruning fixed initializeWriter parametrized TestQueryMergeOnReadOptimizedTable for lance parametrized TestSparkSqlCoreFlow with baseFileFormat added HoodieLanceInputFormat and HoodieLanceRealtimeInputFormat
48b2d92 to
0558b63
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18375 +/- ##
============================================
- Coverage 68.38% 66.14% -2.25%
+ Complexity 27505 26822 -683
============================================
Files 2428 2436 +8
Lines 132926 133340 +414
Branches 16000 16044 +44
============================================
- Hits 90902 88192 -2710
- Misses 34964 38190 +3226
+ Partials 7060 6958 -102
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Closes #18268
Summary and Changelog
Added
HoodieLanceInputFormat,HoodieLanceRealtimeInputFormatandHoodieLanceRecordReader(similar to HFile format).Parametrized Spark-Sql tests
TestSparkSqlCoreFlow,TestSqlStatementandTestQueryMergeOnReadOptimizedTablewith baseFileFormat (parquet/lance) and fixed bugs.Impact
Spark-SQL works correctly when using lance as base file format
Risk Level
low
Documentation Update
none
Contributor's checklist