improve bounds checking for line length validation#624
Open
metsw24-max wants to merge 1 commit intoapache:trunkfrom
Open
improve bounds checking for line length validation#624metsw24-max wants to merge 1 commit intoapache:trunkfrom
metsw24-max wants to merge 1 commit intoapache:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves bounds checking logic in
mod_substitutewithin Apache HTTP ServerReplaces combined arithmetic validation with step-wise boundary checks
Ensures
vb.strlen,len, andreplenremain withinmax_line_lengthlimitsUpdates conditions to avoid reliance on aggregated expressions for validation
Applies consistent bounds checking pattern across related code paths
Adjusts checks involving
space_leftto use safe comparisonsRefines validation of
regm[0].rm_soagainst remaining buffer spacePrevents operations from exceeding configured buffer limits