Fix HTTP/2 stream priority memory leak by dropping unused PriorityValue cache from AbstractH2StreamMultiplexer.#617
Open
arturobernalg wants to merge 1 commit intoapache:masterfrom
Open
Conversation
ok2c
requested changes
Feb 14, 2026
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
Outdated
Show resolved
Hide resolved
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java
Outdated
Show resolved
Hide resolved
…ue cache from AbstractH2StreamMultiplexer.
arturobernalg
force-pushed
the
leak_priority
branch
from
9afd61d to
0bdb769
Compare
ok2c
requested changes
Feb 16, 2026
| requestSessionOutput(); | ||
| final PriorityValue pv = parsePriorityValue(field); | ||
| if (pv != null) { | ||
| final H2Stream prioritizedStream = streams.lookup(prioritizedId); |
Member
There was a problem hiding this comment.
@arturobernalg Why are we ignoring prioritizedId that produce no match? Should we at least reject ids that have never been seen?
| } | ||
| try { | ||
| return PriorityParamsParser.parse(header).toValueWithDefaults(); | ||
| } catch (final IllegalArgumentException ignore) { |
Member
There was a problem hiding this comment.
@arturobernalg Does the parser throw IllegalArgumentException, like, ever?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.