Disable settings_push_enable on the H2Config for H2ServerBootstrap #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@CoolTomatos The setting has no effect on the server side. Please see https://github.com/apache/httpcomponents-core/blob/master/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/ServerH2StreamMultiplexer.java#L96 |
ok2c
requested changes
Dec 26, 2025
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java
Outdated
Show resolved
Hide resolved
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java
Show resolved
Hide resolved
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Hi @ok2c, thanks for the swift response. Will update and request your review on it. |
CoolTomatos
force-pushed
the
no-server-push-for-server
branch
from
f2ece3f to
a73a9b5
Compare
CoolTomatos
force-pushed
the
no-server-push-for-server
branch
from
a73a9b5 to
4d918d1
Compare
ok2c
reviewed
Dec 27, 2025
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2ServerBootstrap.java
Outdated
Show resolved
Hide resolved
Member
|
@CoolTomatos There are test failures but they are not related to your changes. Please bear with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 9113 6.5.2: