HTTPCORE-775: The SSLIOSession::write does not handle SSLEngineResult#BUFFER_OVERFLOW #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#BUFFER_OVERFLOW Signed-off-by: Andriy Redko <drreta@gmail.com>
ok2c
approved these changes
Jan 13, 2025
| .loadKeyMaterial(keyStoreURL, storePassword.toCharArray(), storePassword.toCharArray()); | ||
|
|
||
| if (protocol != null) { | ||
| sslContextBuilder = sslContextBuilder.setProtocol(protocol); |
| this(scheme, null); | ||
| } | ||
|
|
||
| public H2CoreTransportTest(final URIScheme scheme, final String protocol) { |
Member
There was a problem hiding this comment.
@reta Can we give the variable a better name to make it clearer what protocol it is? tlsVersion or tlsProtocol maybe?
Signed-off-by: Andriy Redko <drreta@gmail.com>
Member
Author
Member
|
@reta Cherry-picked to |
|
We believe we hit this bug, and grateful for fix. However, are their any timeouts that should of had an impact on this infinite loop? |
Member
Author
I think the loop is infinite in theory, what is happening under the hood is just buffer adjustment: should be quick and only could fail with allocation exception. I am wondering have you seen the infinite spin in the wild? Thank you. |
|
We ran into a scenario where randomly our cpu would spike and we narrowed
it down to a hung thread from IOReactor threadpool. We do not know what
was so special about the endpoint we were hitting or what could cause this
thread to just go wild and never return to threadpool. After updating to
this version, we have not seen it again.
We updated from
Http client 5.4.2 > 5.4.3 httpcore 5.3.3 > 5.3.4
…On Tue, May 13, 2025 at 8:59 PM Andriy Redko ***@***.***> wrote:
*reta* left a comment (apache/httpcomponents-core#513)
<#513 (comment)>
We believe we hit this bug, and grateful for fix. However, are their any
timeouts that should of had an impact on this infinite loop?
I think the loop is infinite in theory, what is happening under the hood
is just buffer adjustment: should be quick and only could fail with
allocation exception. I am wondering have you seen the infinite spin in the
wild? Thank you.
—
Reply to this email directly, view it on GitHub
<#513 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPLPCQ6MLHUIN36LNAQ5HL26KIPNAVCNFSM6AAAAABVBNBVMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNZYGMZDMNZQGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSLIOSession::write does not handle SSLEngineResult#BUFFER_OVERFLOW. The suggested fix it to make sure there is enough place in the output buffer to store
SSLSession#getPacketBufferSize()bytes. Closes https://issues.apache.org/jira/browse/HTTPCORE-775