Skip to content

HTTPCLIENT-2434 - Improve idle connection eviction configuration. #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arturobernalg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HTTPCLIENT-2434 - Improve idle connection eviction configuration. #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/H2AsyncClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,10 @@ public final H2AsyncClientBuilder disableAuthCaching() {
* get closed and evicted from the pool.
*
* @return this instance.
* @deprecated Configure connection keep-alive settings appropriately and use
* {@link #evictExpiredConnections()} instead.
*/
@Deprecated
public final H2AsyncClientBuilder evictIdleConnections(final TimeValue maxIdleTime) {
this.evictIdleConnections = true;
this.maxIdleTime = maxIdleTime;
Expand Down
3 changes: 3 additions & 0 deletions httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/HttpAsyncClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,10 @@ public final HttpAsyncClientBuilder evictExpiredConnections() {
* get closed and evicted from the pool.
*
* @return this instance.
* @deprecated Configure connection keep-alive settings appropriately and use
* {@link #evictExpiredConnections()} instead.
*/
@Deprecated
public final HttpAsyncClientBuilder evictIdleConnections(final TimeValue maxIdleTime) {
this.evictIdleConnections = true;
this.maxIdleTime = Args.notNull(maxIdleTime, "Max idle time");
Expand Down
3 changes: 3 additions & 0 deletions httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,10 @@ public final HttpClientBuilder evictExpiredConnections() {
*
* @return this instance.
* @since 4.4
* @deprecated Configure connection keep-alive settings appropriately and use
* {@link #evictExpiredConnections()} instead.
*/
@Deprecated
public final HttpClientBuilder evictIdleConnections(final TimeValue maxIdleTime) {
this.evictIdleConnections = true;
this.maxIdleTime = Args.notNull(maxIdleTime, "Max idle time");
Expand Down
20 changes: 8 additions & 12 deletions ...ent5/src/test/java/org/apache/hc/client5/http/examples/ClientEvictExpiredConnections.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,27 +27,31 @@
package org.apache.hc.client5.http.examples;

import org.apache.hc.client5.http.classic.methods.HttpGet;
import org.apache.hc.client5.http.config.RequestConfig;
import org.apache.hc.client5.http.impl.classic.CloseableHttpClient;
import org.apache.hc.client5.http.impl.classic.HttpClients;
import org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager;
import org.apache.hc.core5.http.io.entity.EntityUtils;
import org.apache.hc.core5.http.message.StatusLine;
import org.apache.hc.core5.pool.PoolStats;
import org.apache.hc.core5.util.TimeValue;

/**
* Example demonstrating how to evict expired and idle connections
* from the connection pool.
* Example demonstrating how to configure connection keep-alive and
* evict expired connections from the connection pool.
*/
public class ClientEvictExpiredConnections {

public static void main(final String[] args) throws Exception {
final PoolingHttpClientConnectionManager cm = new PoolingHttpClientConnectionManager();
cm.setMaxTotal(100);

final RequestConfig requestConfig = RequestConfig.custom()
.setConnectionKeepAlive(TimeValue.ofSeconds(5))
.build();
try (final CloseableHttpClient httpclient = HttpClients.custom()
.setConnectionManager(cm)
.setDefaultRequestConfig(requestConfig)
.evictExpiredConnections()
.evictIdleConnections(TimeValue.ofSeconds(5))
.build()) {
// create an array of URIs to perform GETs on
final String[] urisToGet = {
Expand All @@ -69,14 +73,6 @@ public static void main(final String[] args) throws Exception {
});
}

final PoolStats stats1 = cm.getTotalStats();
System.out.println("Connections kept alive: " + stats1.getAvailable());

// Sleep 10 sec and let the connection evictor do its job
Thread.sleep(10000);

final PoolStats stats2 = cm.getTotalStats();
System.out.println("Connections kept alive: " + stats2.getAvailable());

}
}
Expand Down