HIVE-28184: Fix HiveServer2 WebUI "Configure logging" page - #6732
Open
ashniku wants to merge 2 commits into
Open
HIVE-28184: Fix HiveServer2 WebUI "Configure logging" page#6732ashniku wants to merge 2 commits into
ashniku wants to merge 2 commits into
Conversation
- Always render the logger form instead of gating it on active sessions, so logging can be configured even with no open JDBC session. - Populate a logger dropdown from /conflog and auto-select each logger's current level; show the root logger as "(root)". - Fix Log4j2ConfiguratorServlet so setting a not-yet-configured child logger adds a new logger instead of changing an existing ancestor. - POST level updates as application/json and treat the empty 200 response as success; render the table via text() to avoid HTML injection. - Add TestLog4j2ConfiguratorServlet unit tests covering new/child/root loggers and every supported level.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
Why are the changes needed?
The page could not configure logging when there were no active sessions, could accidentally change a parent logger's level, displayed the root logger as a blank row, and showed a spurious error on every successful update. Together these made the feature effectively unusable.
Does this PR introduce any user-facing change?
Yes — WebUI only. The "Configure logging" page now shows a populated logger dropdown, correctly applies levels, labels the root logger (root), and no longer shows a false error on success. No API/CLI/config changes.
How was this patch tested?