Skip to content

HIVE-29719: NegativeArraySizeException in HybridGrace HashJoin due to integer overflow #6593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aggarwal-Raghav wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

HIVE-29719: NegativeArraySizeException in HybridGrace HashJoin due to integer overflow #6593

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/HybridHashTableContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,12 +701,17 @@ public static int calcNumPartitions(long memoryThreshold, long dataSize, int min
int minWbSize) throws IOException {
int numPartitions = minNumParts;

if (memoryThreshold < minNumParts * minWbSize) {
if (memoryThreshold < (long) minNumParts * minWbSize) {
LOG.warn("Available memory is not enough to create a HybridHashTableContainer!");
}

if (memoryThreshold / 2 < dataSize) { // The divided-by-2 logic is consistent to MapJoinOperator.reloadHashTable
while (dataSize / numPartitions > memoryThreshold / 2) {
// Prevent integer overflow
if (numPartitions > Integer.MAX_VALUE / 2) {
throw new IOException("Cannot create a Hybrid Grace Hash Join with a table size this large ("
+ dataSize + " bytes) against a memory threshold of " + memoryThreshold + " bytes");
}
numPartitions *= 2;
}
}
Expand Down
Loading