HIVE-29690: Fix StackOverflowError when calling get_table_objects_by_name_req API with both tablenames and pattern#6573
Open
vikramahuja1001 wants to merge 2 commits into
Open
Conversation
vikramahuja1001
force-pushed
the
HIVE-29690
branch
from
72c45a7 to
d2d41d7
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
…name_req API with both tablenames and pattern
vikramahuja1001
force-pushed
the
HIVE-29690
branch
from
22e4729 to
99aa65a
Compare
|
Contributor
Author
|
@deniskuzZ , @zabetak , @zhangbutao , @ayushtkn could someone please check this PR when you get a chance? Thanks. |
deniskuzZ
reviewed
Jul 12, 2026
| if(req.getTablesPattern() != null) { | ||
| tables = ms.getTableObjectsByName(catName, dbName, tableNames, projectionsSpec, req.getTablesPattern()); | ||
| // case : tableNames is empty -> return empty list | ||
| if (tableNames != null && tableNames.isEmpty()) { |
deniskuzZ
reviewed
Jul 12, 2026
|
|
||
| // case : tableNames != null and pattern == null -> batched flow | ||
| // case : tableNames != null and pattern != null -> batched flow with pattern filter | ||
| String tablesPattern = req.getTablesPattern(); |
Member
There was a problem hiding this comment.
can we drop these comments and inline thereq.getTablesPattern() usage?
deniskuzZ
reviewed
Jul 12, 2026
| return tables; | ||
| } | ||
|
|
||
| if (req.getTablesPattern() != null && tableNames == null) { |
Member
There was a problem hiding this comment.
I think the original code was designed to support either the pattern or the names list
cc @saihemanth-cloudera, @dengzhhu653
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Setting batching on the basis of tableNames rather than tablePattern
Why are the changes needed?
Check JIRA HIVE-29690 for the same.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tested with a custom test Program mentioned in the JIRA.