HIVE-29452: Split get table from HMSHandler by dengzhhu653 · Pull Request #6427 · apache/hive

dengzhhu653 · 2026-04-13T01:50:49Z

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Copilot

Pull request overview

This PR refactors Hive Metastore “get table”-related logic by moving several table retrieval/listing flows out of HMSHandler into a dedicated GetTableHandler request handler, aligning with the existing request-handler architecture used elsewhere in the standalone metastore server.

Changes:

Introduces GetTableHandler to centralize implementations for get_table_req, get_table_core, get_table_objects_by_name_req, and various table-name listing methods.
Updates HMSHandler to delegate these operations to GetTableHandler and removes now-duplicated helper logic.
Improves an UnsupportedOperationException message in GetPartitionsHandler to include the unsupported request object.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java`	Delegates multiple table APIs to the new `GetTableHandler` and removes inlined implementations.
`standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/GetTableHandler.java`	New request handler consolidating table fetch/list logic previously in `HMSHandler`.
`standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/GetPartitionsHandler.java`	Makes the “not yet implemented” exception include the request value for easier debugging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/GetTableHandler.java

...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:1449

In get_table_req, exceptions from GetTableHandler.getTable(...) aren't captured/passed to endFunction (the Exception argument is always null). This can hide failures from end-function listeners/metrics and produces misleading audit/telemetry. Capture the exception in a local Exception ex (as other HMSHandler methods do), rethrow it, and pass ex to endFunction.

  @Override
  public List<TableMeta> get_table_meta(String dbnames, String tblNames, List<String> tblTypes)
      throws MetaException, NoSuchObjectException {
    List<TableMeta> t = null;
    String[] parsedDbName = parseDbName(dbnames, conf);
    startTableFunction("get_table_metas", parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tblNames);
    Exception ex = null;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java

sonarqubecloud · 2026-04-14T11:16:13Z

Quality Gate passed

Issues
35 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

wecharyu

Looks good overall, just left a few minor comments.

wecharyu · 2026-04-14T16:32:34Z

...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/GetTableHandler.java

+   * then engine should be specified so the table is retrieve with the column stats
+   * for that engine.
+   */
+  private Table getTable(GetTableRequest getTableRequest) throws MetaException, NoSuchObjectException {


Could we add comments to highlight the differences from getTableCore()?

wecharyu · 2026-04-14T16:35:47Z

...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java

-    }
-    return t;
+    return GetTableHandler.getTables(
+        () -> startTableFunction("get_table_metas", parsedDbName[CAT_NAME], parsedDbName[DB_NAME], tblNames),


nit: get_table_metas => get_table_meta

wecharyu · 2026-04-14T16:43:11Z

...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java

-    }
-    return tables;
+    List<Table> tables = GetTableHandler.getTables(
+        () -> startMultiTableFunction("get_multi_table", req.getDbName(), req.getTblNames()),


nit: get_multi_table => get_table_objects

wecharyu · 2026-04-14T16:57:59Z

...metastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/GetTableHandler.java

+    try {
+      Database database = handler.get_database_core(catName, dbname);
+      if (isDatabaseRemote(database)) {
+        return DataConnectorProviderFactory.getDataConnectorProvider(database).getTableNames();


It does not filter out the result by possible filter or pattern.

HIVE-29452: Split get table from HMSHandler

8afaae0

asf-ci-hive added the tests pending label Apr 13, 2026

dengzhhu653 requested a review from Copilot April 13, 2026 01:59

Copilot started reviewing on behalf of dengzhhu653 April 13, 2026 02:00 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

review-1

0ee852c

asf-ci-hive added tests failed and removed tests pending labels Apr 13, 2026

dengzhhu653 requested a review from Copilot April 13, 2026 03:21

Copilot started reviewing on behalf of dengzhhu653 April 13, 2026 03:21 View session

Copilot AI reviewed Apr 13, 2026

View reviewed changes

...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java Outdated Show resolved Hide resolved

...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java Show resolved Hide resolved

review-2

d381e86

asf-ci-hive added tests pending tests unstable and removed tests failed tests pending labels Apr 13, 2026

fix ut

caaf47c

asf-ci-hive added tests pending tests unstable and removed tests unstable tests pending labels Apr 14, 2026

fix

44b6880

asf-ci-hive added tests pending and removed tests unstable labels Apr 14, 2026

asf-ci-hive added tests unstable and removed tests pending labels Apr 14, 2026

wecharyu reviewed Apr 14, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HIVE-29452: Split get table from HMSHandler#6427

HIVE-29452: Split get table from HMSHandler#6427
dengzhhu653 wants to merge 5 commits intoapache:masterfrom
dengzhhu653:HIVE-29452

dengzhhu653 commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 14, 2026

Uh oh!

wecharyu left a comment

Uh oh!

wecharyu Apr 14, 2026

Uh oh!

wecharyu Apr 14, 2026

Uh oh!

wecharyu Apr 14, 2026

Uh oh!

wecharyu Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dengzhhu653 commented Apr 13, 2026

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 14, 2026

Quality Gate passed

Uh oh!

wecharyu left a comment

Choose a reason for hiding this comment

Uh oh!

wecharyu Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

wecharyu Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

wecharyu Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

wecharyu Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants