HIVE-29560: Fix JdbcColumn DECIMAL class mapping to BigDecimal#6424
Open
kezhuoquan wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29560: Fix JdbcColumn DECIMAL class mapping to BigDecimal#6424kezhuoquan wants to merge 1 commit intoapache:masterfrom
kezhuoquan wants to merge 1 commit intoapache:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
JdbcColumn.columnClassName()currently mapsTypes.DECIMALtoBigInteger.class.getName(), which is incorrect for DECIMAL semantics.This PR changes the mapping to
BigDecimal.class.getName().Why are the changes needed?
JDBC
DECIMALshould map tojava.math.BigDecimal, notBigInteger.The current behavior may cause type mismatch and incorrect metadata
interpretation by JDBC clients.
Does this PR introduce any user-facing change?
Yes.
For DECIMAL columns, JDBC metadata now reports
java.math.BigDecimalas the column class name.How was this patch tested?
mvn -pl jdbc -DskipTests compilejdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java