Consolidate entity-free observability for 1.9 - #4302
Open
zqr10159 wants to merge 15 commits into
Open
Conversation
…free-observability # Conflicts: # script/docker-compose/hertzbeat-mysql-iotdb/conf/sureness.yml # script/docker-compose/hertzbeat-mysql-tdengine/conf/sureness.yml # script/docker-compose/hertzbeat-mysql-victoria-metrics/conf/sureness.yml # script/docker-compose/hertzbeat-postgresql-greptimedb/conf/sureness.yml # script/docker-compose/hertzbeat-postgresql-victoria-metrics/conf/sureness.yml # script/sureness.yml
…free-observability
…nd document 1.9 route changes Co-authored-by: Logic <zqr10159@dromara.org>
…rver at hzb_internal_logs Co-authored-by: Logic <zqr10159@dromara.org>
…forwardHttp Co-authored-by: Logic <zqr10159@dromara.org>
Co-authored-by: Logic <zqr10159@dromara.org>
… of retryable 503 Co-authored-by: Logic <zqr10159@dromara.org>
…d of sleeping 5.5s Co-authored-by: Logic <zqr10159@dromara.org>
Aias00
approved these changes
Aug 17, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Review: Consolidate entity-free observability for 1.9
Verdict: ✅ APPROVED (scoped review) — large, well-tested refactor; high-risk surfaces check out.
Scope note: this is a +3,149 / −1,488, 123-file change. I did a scoped review focused on the risk areas rather than a full line-by-line pass. The author's validation matrix (e2e against real GreptimeDB over HTTP+gRPC, 25 warehouse + 22 observability tests, transition contracts, UI tests, full reactor build) is strong.
What I verified
- Module rename is complete: no leftover
hertzbeat-logreferences in non-test sources (only in assertions that prove the rename). Build should not have dangling imports. There's even aContextTestassertingThreeSignalQueryController/OtlpSignalControllernow resolve fromhertzbeat.observability. - Auth config is coherent with the code changes:
/api/otlp/**===postnarrowed to/api/otlp/v1/**===post; old anonymous/api/observability/capability===getwas removed fromexcludedResourceand now requires a logged-in (guest+) role — a tightening, not a regression.- Removed GET rules (
/api/ingestion/otlp/metrics/console,.../inventory) correspond to endpoints that were deleted in the same PR — rules and code stay in sync. - Deprecated
/api/logs/otlp/**is kept as an alias forwarded to the canonical/api/otlp/v1/logs, with a note it's removed in 2.0.
- Dependencies: only
hertzbeat-observability/hertzbeat-observability-e2eare added; no new third-party deps introduced at a glance. - GreptimeDB integration is covered by a real
GenericContainere2e test (HTTP + gRPC write/query), andGREPTIME_QUERY_READ_TIMEOUTwas bumped 5s→15s with a rationale.
Non-blocking suggestions
- Greptime schema files: the e2e test references
greptime/tables/hertzbeat_logs.sqlandgreptime/pipelines/hertzbeat_otlp_log_v1.yaml. Please confirm these resource files are added in this PR (the e2e would fail in CI otherwise, so CI is the backstop — just worth a manual glance). - Broad GET rule:
/api/observability/**===get===[admin,user,guest]consolidates the former per-signal guest-read rules. Please double-check no sensitive GET endpoint under/api/observabilityis now unexpectedly guest-readable.
No blocking issues found in the scoped review. Good work on the transition boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hertzbeat-observabilityand move entity-free signal storage/query ownership into the warehouse layerMotivation
The 1.9 release is the transition release before the 2.0 entity model. It needs the mature three-signal ingestion and query boundary without introducing the entity layer. This change consolidates those capabilities under observability and warehouse ownership while preserving the 1.9 operator routes and resource-based filtering model.
Validation
./mvnw -pl hertzbeat-startup -am -DskipTests package: all 24 reactor modules succeeded and produced the 1.9 startup jarnpm run package: production build succeededgit diff --checkpassedUpgrade impact
hertzbeat-logtohertzbeat-observabilityhertzbeat-warehouseAI assistance: used for draft implementation and test iteration.
Human validation: ran the commands and real HTTP/gRPC/Greptime/browser checks listed above; all required checks passed.
Risk notes: the live local smoke used the cached GreptimeDB 1.0.1 image while repository Compose targets 1.1.3, so CI/E2E remains the final pinned-version proof. The Angular production build retains the repository's existing 3.12 MB initial-bundle budget warning. Existing unrelated full-catalog locale drift was not expanded; all keys added here are present in all five touched catalogs.