Skip to content

HBASE-30382: Update zstd-jni to 1.5.7-15 (branch-2) - #8657

Open
arvindKandpal-ksolves wants to merge 1 commit into
apache:branch-2from
arvindKandpal-ksolves:HBASE-30382-branch-2
Open

arvindKandpal-ksolves wants to merge 1 commit into
apache:branch-2from
arvindKandpal-ksolves:HBASE-30382-branch-2

Conversation

@arvindKandpal-ksolves

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Bumps zstd-jni from 1.5.7-2 to 1.5.7-15 in pom.xml (branch-2).

Why are the changes needed?

zstd-jni versions prior to 1.5.7-14 contain vulnerable code addressed by:

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Ran the full zstd-jni compression test suite before and after the bump:
TestWALCompressionZstd, TestZstdCodec, TestHFileCompressionZstd,
TestZstdDictionary, TestZstdDictionarySplitMerge, TestZstdByteBuffDecompressor.

Baseline (1.5.7-2): 15 tests run, 0 failures, 0 errors
After bump (1.5.7-15): 15 tests run, 0 failures, 0 errors

Verified via mvn dependency:tree that the resolved artifact is
com.github.luben:zstd-jni:jar:1.5.7-15.

Note: built with -Dhadoop.profile=3.0 (required for JDK11+).

@PDavid

PDavid commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Hi @arvindKandpal-ksolves,
Can you please check similarly to the master PR that the tests which failed in the PR builds are actually successful locally on this branch?

@arvindKandpal-ksolves

Copy link
Copy Markdown
Contributor Author

Verified locally on branch-2 across all 3 failing JDK/Hadoop CI jobs.

JDK17/Hadoop3 (large-wave-3):

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -Dhadoop.profile=3.0 -pl hbase-server -am clean install -DskipTests 2>&1 | tail -10
[INFO] Apache HBase - HTTP ................................ SUCCESS [  5.033 s]
[INFO] Apache HBase - Asynchronous FileSystem ............. SUCCESS [  4.802 s]
[INFO] Apache HBase - Procedure ........................... SUCCESS [  3.199 s]
[INFO] Apache HBase - Server .............................. SUCCESS [ 57.579 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:45 min
[INFO] Finished at: 2026-09-17T20:57:05+05:30
[INFO] ------------------------------------------------------------------------

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -Dhadoop.profile=3.0 -pl hbase-server test -Dtest=TestStochasticLoadBalancerBalanceCluster#testBalanceCluster -DfailIfNoTests=false 2>&1 | grep -E "Tests run|FAIL|ERROR|BUILD"
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 58.86 s -- in org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancerBalanceCluster
[ERROR] Surefire is going to kill self fork JVM. The exit has elapsed 30 seconds after System.exit(0).
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] BUILD SUCCESS

JDK11/Hadoop3 (large-wave-1):

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -Dhadoop.profile=3.0 -pl hbase-server -am clean install -DskipTests 2>&1 | tail -10
[INFO] Apache HBase - HTTP ................................ SUCCESS [  5.100 s]
[INFO] Apache HBase - Asynchronous FileSystem ............. SUCCESS [  5.518 s]
[INFO] Apache HBase - Procedure ........................... SUCCESS [  3.541 s]
[INFO] Apache HBase - Server .............................. SUCCESS [ 52.835 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:39 min
[INFO] Finished at: 2026-09-17T21:19:40+05:30
[INFO] ------------------------------------------------------------------------

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -Dhadoop.profile=3.0 -pl hbase-server test -Dtest=TestEditsBehindDroppedTableTiming#testEditsBehindDroppedTableTiming -DfailIfNoTests=false 2>&1 | grep -E "Tests run|FAIL|ERROR|BUILD"
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.5 s -- in org.apache.hadoop.hbase.replication.TestEditsBehindDroppedTableTiming
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] BUILD SUCCESS

JDK8/Hadoop2 (large-wave-1):

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -pl hbase-server -am clean install -DskipTests 2>&1 | tail -10
[INFO] Apache HBase - HTTP ................................ SUCCESS [  4.251 s]
[INFO] Apache HBase - Asynchronous FileSystem ............. SUCCESS [  3.876 s]
[INFO] Apache HBase - Procedure ........................... SUCCESS [  2.419 s]
[INFO] Apache HBase - Server .............................. SUCCESS [ 36.255 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:58 min
[INFO] Finished at: 2026-09-17T21:26:16+05:30
[INFO] ------------------------------------------------------------------------

arvindksi274@KLP2757:~/Opensource-works/hbase$ mvn -pl hbase-server test -Dtest=TestFromClientSide3#testMultiRowMutations,TestFromClientSide3WithCoprocessor#testMultiRowMutations,TestFlushSnapshotFromClient#testFlushTableSnapshotWithProcedure,TestCanaryTool#testWebUI,TestClientScannerTimeouts -DfailIfNoTests=false 2>&1 | grep -E "Tests run|FAIL|ERROR|BUILD"
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.1 s -- in org.apache.hadoop.hbase.client.TestFromClientSide3
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 112.4 s -- in org.apache.hadoop.hbase.client.TestFromClientSide3WithCoprocessor
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 23.08 s <<< FAILURE! -- in org.apache.hadoop.hbase.tool.TestCanaryTool
[ERROR] org.apache.hadoop.hbase.tool.TestCanaryTool.testWebUI -- Time elapsed: 22.96 s <<< ERROR!
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.82 s -- in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
[INFO] Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 230.6 s -- in org.apache.hadoop.hbase.client.TestClientScannerTimeouts
[ERROR] Errors: 
[ERROR]   TestCanaryTool.testWebUI:461->getPageContent:581 IllegalState Could not get Canary status page.
[ERROR] Tests run: 40, Failures: 0, Errors: 1, Skipped: 0
[INFO] BUILD FAILURE
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on project hbase-server: 
[ERROR] 
[ERROR] See /home/arvindksi274/Opensource-works/hbase/hbase-server/target/surefire-reports for the individual test results.
[ERROR] See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

TestFromClientSide3, TestFromClientSide3WithCoprocessor, TestFlushSnapshotFromClient, TestClientScannerTimeouts — all pass.

TestCanaryTool#testWebUI fails with "Could not get Canary status page." Same failure seen on branch-2.6 — confirmed there at the code level: no reference to zstd/compress anywhere in TestCanaryTool.java or CanaryTool.java. It's a pure HTTP fetch/retry against an embedded Jetty status server, and CI itself already classifies this as "Flakes" (intermittent, not deterministic).

@arvindKandpal-ksolves

Copy link
Copy Markdown
Contributor Author

Hi @PDavid, I have tested all the failed tests on all branches, and for the tests that failed locally, I reverted my changes and reproduced the same failure without my fix. So I believe these failures are not related to our changes.

I have commented my run outputs in each PR , could you please check and verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants