HBASE-29936 RegionServerRpcQuotaManager throws NPE in checkScanQuota and checkBatchQuota when quotaCache is null#7815
Open
dParikesit wants to merge 3 commits intoapache:masterfrom
Conversation
liuxiaocs7
reviewed
Feb 27, 2026
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestRegionServerRpcQuotaManager.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: HBASE-29936
When a RpcThrottlingException is raised during checkScanQuota or checkBatchQuota, the error handler always calls quotaCache.getQuotaUserName(ugi). If quota is disabled (
hbase.quota.enabled: false), quotaCache will be null, so the exception handler itself throws NullPointerException. This masks the original RpcThrottlingException and can break RPC handling when quotas are disabled or not yet initialized.We propose to add
isQuotaEnabled()check in the exception handling and useugi.getUserName()if the quota is disabled.