GROOVY-12146: order reflection calls to ensure Annotation members are ordered#2690
Open
jdaugherty wants to merge 1 commit into
Open
GROOVY-12146: order reflection calls to ensure Annotation members are ordered#2690jdaugherty wants to merge 1 commit into
jdaugherty wants to merge 1 commit into
Conversation
…bytecode, breaking reproducible builds
Contributor
Author
|
@paulk-asert I found more issues after verifying the restage. MOP bridge methods & Woven trait methods. I used a similar fix and extracted the logic to a shared location. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## GROOVY_5_0_X #2690 +/- ##
======================================================
- Coverage 67.2505% 67.2476% -0.0029%
- Complexity 29569 29570 +1
======================================================
Files 1382 1382
Lines 116991 116999 +8
Branches 20551 20551
======================================================
+ Hits 78677 78679 +2
- Misses 31787 31791 +4
- Partials 6527 6529 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes:
Sorting is behavior-neutral: member order carries no semantic meaning in these paths; it only affects the byte layout of emitted class files.