Skip to content

GROOVY-12133: Implement findBalancedGroups utility to support Regex Balanced Groups#2669

Open
daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12133
Open

GROOVY-12133: Implement findBalancedGroups utility to support Regex Balanced Groups#2669
daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12133

Conversation

@daniellansun

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 4ed8450 Previous: 6047948 Ratio
org.apache.groovy.bench.StaticMethodCallIndyBench.staticChain_groovyCS 2517.4197980828194 ops/ms 1639.7481241208068 ops/ms 1.54
org.apache.groovy.bench.StaticMethodCallIndyBench.staticChain_java 2513.6830789861524 ops/ms 1672.0161367479286 ops/ms 1.50
org.apache.groovy.bench.AckermannBench.java ( {"n":"7"} ) 1.1933870638637274 ms/op 0.6834843885596149 ms/op 1.75
org.apache.groovy.bench.AryBench.groovyCS ( {"n":"1000"} ) 0.05891150855531278 ms/op 0.038886917037119204 ms/op 1.51
org.apache.groovy.bench.AryBench.java ( {"n":"1000"} ) 0.08926114532677085 ms/op 0.04789990086353664 ms/op 1.86
org.apache.groovy.bench.CalibrationBench.memoryPointerChase 1008.4655744339489 us/op 472.26134438207356 us/op 2.14
org.apache.groovy.bench.StaticMethodCallIndyColdBench.staticSum_java ( {"n":"2000"} ) 51.071149999999996 us/op 33.582312499999986 us/op 1.52
org.apache.groovy.bench.StaticMethodCallIndyColdBench.staticSum_java ( {"n":"20000"} ) 436.9545625000002 us/op 255.07206249999996 us/op 1.71

This comment was automatically generated by workflow using github-action-benchmark.

@codecov-commenter

codecov-commenter commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.79832% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.1313%. Comparing base (c9363db) to head (4ed8450).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/groovy/util/regex/BalancedGroup.java 95.7265% 1 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2669        +/-   ##
==================================================
+ Coverage     69.1083%   69.1313%   +0.0230%     
- Complexity      34235      34281        +46     
==================================================
  Files            1537       1538         +1     
  Lines          129310     129429       +119     
  Branches        23478      23506        +28     
==================================================
+ Hits            89364      89476       +112     
- Misses          31936      31941         +5     
- Partials         8010       8012         +2     
Files with missing lines Coverage Δ
...g/codehaus/groovy/runtime/StringGroovyMethods.java 82.2955% <100.0000%> (+0.0433%) ⬆️
src/main/java/groovy/util/regex/BalancedGroup.java 95.7265% <95.7265%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

JMH summary — classic (commit 3fefb08)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 0.995 × 0.978 × 84
core 1.027 × 1.054 × 77
grails 1.059 × 1.082 × 80

Runner calibration (this run vs baseline hardware): bench 1.01× (26 rulers) · core-ag 0.96× (3 rulers) · core-hz 1.00× (3 rulers) · grails-ad 0.97× (3 rulers) · grails-ez 0.99× (3 rulers)

Baseline: dev/bench/jmh/<part>/classic/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

JMH summary — indy (commit 3fefb08)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 0.971 × 1.003 × 84
core 3.514 × 3.272 × 77
grails 2.267 × 2.399 × 80

Runner calibration (this run vs baseline hardware): bench 0.96× (26 rulers) · core-ag 1.13× (3 rulers) · core-hz 1.02× (3 rulers) · grails-ad 0.97× (3 rulers) · grails-ez 0.93× (3 rulers)

Baseline: dev/bench/jmh/<part>/indy/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@asf-gitbox-commits asf-gitbox-commits force-pushed the GROOVY-12133 branch 4 times, most recently from e3ca356 to ee53ae6 Compare July 5, 2026 16:45
@daniellansun daniellansun requested a review from paulk-asert July 5, 2026 16:49
@daniellansun daniellansun changed the title GROOVY-12133: Implement matchBalanced utility to support Regex Balanced Groups GROOVY-12133: Implement findBalanced utility to support Regex Balanced Groups Jul 5, 2026
@asf-gitbox-commits asf-gitbox-commits force-pushed the GROOVY-12133 branch 8 times, most recently from a60c37a to a74aa8f Compare July 12, 2026 16:54
@daniellansun daniellansun changed the title GROOVY-12133: Implement findBalanced utility to support Regex Balanced Groups GROOVY-12133: Implement findBalancedGroups utility to support Regex Balanced Groups Jul 12, 2026
@asf-gitbox-commits asf-gitbox-commits force-pushed the GROOVY-12133 branch 3 times, most recently from 6026310 to 50dbd6b Compare July 12, 2026 18:12
@sonarqubecloud

Copy link
Copy Markdown

@testlens-app

testlens-app Bot commented Jul 12, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: 4ed8450
▶️ Tests: 103991 executed
⚪️ Checks: 31/31 completed


Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants