[GLUTEN-11635][FOLLOW-UP] Respect partial fallback configs when checking node support#11988
Open
wecharyu wants to merge 1 commit intoapache:mainfrom
Open
[GLUTEN-11635][FOLLOW-UP] Respect partial fallback configs when checking node support#11988wecharyu wants to merge 1 commit intoapache:mainfrom
wecharyu wants to merge 1 commit intoapache:mainfrom
Conversation
philo-he
reviewed
Apr 27, 2026
Member
philo-he
left a comment
philo-he
left a comment
There was a problem hiding this comment.
One comment. Please check if it makes sense. Thank you.
| plan.isInstanceOf[ProjectExec] || | ||
| plan.isInstanceOf[GenerateExec] | ||
| def supportPartialFallback(plan: SparkPlan): Boolean = plan match { | ||
| case _: ProjectExec => GlutenConfig.get.enableColumnarPartialProject |
Member
There was a problem hiding this comment.
I noticed the following code already performs this check before PartialFallback.supportPartialFallback is called. Is this a duplicate?
Contributor
There was a problem hiding this comment.
I think this is to handle situations where the parent and child are different; one is ProjectExec, and the other is GenerateExec.
| plan.isInstanceOf[GenerateExec] | ||
| def supportPartialFallback(plan: SparkPlan): Boolean = plan match { | ||
| case _: ProjectExec => GlutenConfig.get.enableColumnarPartialProject | ||
| case _: GenerateExec => GlutenConfig.get.enableColumnarPartialGenerate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Minor follow up for #11637.
How was this patch tested?
Add UT.
Was this patch authored or co-authored using generative AI tooling?
No.
Related issue: #11635