[VL] Fix duplicate File prefix in FileSourceScanExecTransformer node name on Spark 4.1#11968
Open
srichetar wants to merge 1 commit intoapache:mainfrom
Open
Conversation
…e on Spark 4.1 The simpleString method in FileSourceScanExecTransformerBase prepends nodeNamePrefix to nodeName. On Spark 4.1, AbstractFileSourceScanExec sets nodeNamePrefix='File', but nodeName already contains the full class name (via getClass.getSimpleName) which starts with 'File'. This causes the physical plan to display 'FileFileSourceScanExecTransformer' instead of 'FileSourceScanExecTransformer'. Override nodeNamePrefix to empty string in FileSourceScanExecTransformerBase to prevent the double prefix.
|
Run Gluten Clickhouse CI on x86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Override
nodeNamePrefixto""inFileSourceScanExecTransformerBaseto prevent the scan node from displaying asFileFileSourceScanExecTransformerinstead ofFileSourceScanExecTransformerin physical plans on Spark 4.1.Root cause
AbstractFileSourceScanExecsetsnodeNamePrefix = "File"FileSourceScanExecTransformerBaseoverridesnodeNameusinggetClass.getSimpleNamewhich already starts with "File"simpleStringconcatenatesnodeNamePrefix + nodeNameproducing"File" + "FileSourceScanExecTransformer ..." = "FileFileSourceScanExecTransformer ..."The existing bug report #11402 also incidentally shows
FileFileSourceScanExecTransformerin its plan output, confirming this is not environment-specific.Fix
Add
override val nodeNamePrefix: String = ""inFileSourceScanExecTransformerBaseto prevent the inherited "File" prefix from being prepended to the already-completenodeName.Does this PR introduce any user-facing change?
Yes (cosmetic). Physical plan display shows correct node name (
FileSourceScanExecTransformer) instead ofFileFileSourceScanExecTransformer.How was this tested?
Existing tests. The test class
TestFileSourceScanExecTransformeralready demonstrates thenodeNamePrefixoverride pattern.