[GLUTEN-9456][VL] Cancel load earlier in GlutenDirectBufferedInput destructor#11697
Open
rui-mo wants to merge 1 commit intoapache:mainfrom
Open
[GLUTEN-9456][VL] Cancel load earlier in GlutenDirectBufferedInput destructor#11697rui-mo wants to merge 1 commit intoapache:mainfrom
GlutenDirectBufferedInput destructor#11697rui-mo wants to merge 1 commit intoapache:mainfrom
Conversation
PHILO-HE
reviewed
Mar 4, 2026
|
|
||
| ~GlutenDirectBufferedInput() override { | ||
| requests_.clear(); | ||
| for (auto& load : coalescedLoads_) { |
Member
There was a problem hiding this comment.
Can we unify the two loops into one?
Contributor
Author
There was a problem hiding this comment.
I intentionally moved this forward to cancel the load as early as possible, trying to reduce wait time. Thanks.
rui-mo
changed the title
GlutenDirectBufferedInput destructorGlutenDirectBufferedInput destructor
PHILO-HE
approved these changes
Mar 5, 2026
Member
PHILO-HE
left a comment
PHILO-HE
left a comment
There was a problem hiding this comment.
Looks good. I would suggest adding a comment for explanation. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
While waiting for a load, a planned load may start unnecessarily. This PR cancels the load as early as possible to minimize wait time.
How was this patch tested?
Verified on CI.
Was this patch authored or co-authored using generative AI tooling?
No
Related issue: #9456