feat(c++): add field validation options for cpp generator - #4032
Open
Pastoray wants to merge 1 commit into
Open
Conversation
Pastoray
requested review from
PragmaTwice,
chaokunyang and
theweipeng
as code owners
September 11, 2026 02:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
FDL currently lacks a way to express validation constraints directly in the schema. Users must manually write validation logic in their application code, leading to duplication and boilerplate.
What does this PR do?
Parser: Adds recognition of validation options (
gte,lte,gt,lt,eql,neq,min_len,max_len,pattern,uuid,email,min_items,max_items) as valid field options (silencing the "Unknown option" warning).Semantic Validator: Adds
_check_validation_options()and_check_field_options()to ensure validation options are used on appropriate field types:gte,lte,gt,lt,eql,neq): only on numeric primitive typesmin_len,max_len,pattern,uuid,email): only on string fieldsmin_items,max_items): only on list/array/map fieldsC++ Generator: Adds a
generate_validator()method that emits anamespace Validator { ... }block containing per-message validation functions. For each field option, the generator emits the corresponding C++ check:gte:obj.field() >= valuemin_len:obj.field().size() >= valuepattern:std::regex_match(obj.field(), std::regex(R"(...)"))Unit Test: Adds
test_cpp_validation_options()intest_generated_code.pyverifying that the generated C++ contains the expected checks.Related issues
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence or equivalent persisted links of the final clean AI review results from both fresh reviewers described inAI_POLICY.md, the Fory-guided reviewer and the independent general reviewer, on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Yes, new validation options in FDL fields: