[rpc] Reject inactive lazy requests before queuing - #4461
Open
platinumhamburg wants to merge 3 commits into
Open
platinumhamburg wants to merge 3 commits into
platinumhamburg wants to merge 3 commits into
Conversation
platinumhamburg
marked this pull request as ready for review
September 21, 2026 12:10
platinumhamburg
force-pushed
the
fix-produce-request-buffer-lifecycle
branch
from
September 21, 2026 13:05
2d2f5a8 to
dd4e787
Compare
Prevent inactive lazy requests from reaching request processing with released buffers, and cover the resulting invalid log append path.
platinumhamburg
force-pushed
the
fix-produce-request-buffer-lifecycle
branch
from
September 21, 2026 13:07
dd4e787 to
9116bbf
Compare
Contributor
Author
|
Thank you, @chaohaochen, for identifying the original bug and conducting a thorough investigation and in-depth analysis of its contextual details. After attempting my own analysis and reproduction based on your findings, I believe the current issue represents a high-confidence root cause. Could @chaohaochen, @gyang94, and @swuferhong please take the time to review this PR? |
Contributor
|
@platinumhamburg LGTM +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4460
Prevent inactive lazy requests from reaching the request processor with a released
ByteBuf.Brief change log
NettyServerHandlerTest.RequestProcessorandFileLogRecords.appendpath.Without the fix, the test writes a batch that was valid before buffer release but invalid on disk:
Tests
./mvnw -pl fluss-rpc -am -Dtest=NettyServerHandlerTest -DfailIfNoTests=false testAPI and Format
No API or format changes.
Documentation
Not applicable.