[common] Close input when copy output close fails#3746
Draft
wolfkill wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
IOUtils.copyBytes(..., close = true)currently closes the output stream before the input stream in a single finally block. Ifout.close()throws,in.close()is skipped even though the method contract says both streams are closed in the finally clause.This patch makes the close path attempt both closes and preserves the first close failure, adding any later close failure as suppressed.
Brief change log
copyBytesowns stream closure, even if the first close fails.Verifying this change
RED:
mvn -pl fluss-common -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -DfailIfNoTests=false -Dtest=IOUtilsTest#testCopyBytesClosesInputWhenOutputCloseFails testGREEN:
mvn -pl fluss-common -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -DfailIfNoTests=false -Dtest=IOUtilsTest#testCopyBytesClosesInputWhenOutputCloseFails testmvn -pl fluss-common -am -DskipITs -Dcheckstyle.skip -Dspotless.check.skip=true -DfailIfNoTests=false -Dtest=IOUtilsTest testmvn -pl fluss-common -am -DskipITs -Dspotless.check.skip=true -DfailIfNoTests=false -Dtest=IOUtilsTest testgit diff --checkNote: running the same Maven test command without
-Dspotless.check.skip=truefails in this local JDK environment before reachingfluss-common, influss-test-utilsspotless/google-java-format withNoSuchMethodError: com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics().