[filesystem] avoid zero-skip loop in HadoopDataInputStream#3738
Draft
wolfkill wants to merge 1 commit into
Draft
[filesystem] avoid zero-skip loop in HadoopDataInputStream#3738wolfkill wants to merge 1 commit into
wolfkill wants to merge 1 commit into
Conversation
2 tasks
Contributor
|
would it be better to use the org.apache.hadoop.io.IOUtils.skipFully? |
Author
|
Updated this to use I checked the Hadoop 3.4.0 implementation before changing it: when The regression test now verifies that path by asserting Local verification:
|
wolfkill
force-pushed
the
fix/hadoop-seek-past-eof
branch
from
July 23, 2026 08:39
9c887a3 to
e324d87
Compare
Contributor
|
looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3718.
Root Cause
HadoopDataInputStream.seek()optimizes small forward seeks by skipping instead of issuing a Hadoopseek().The old local
skipFully()loop assumed everyFSDataInputStream.skip(bytes)call makes forward progress. Some streams return0at EOF or when no bytes can currently be skipped. In that case the remaining byte count never decreases and the loop can spin forever.Changes
org.apache.hadoop.io.IOUtils.skipFully(InputStream, long).skipFullyimplementation.EOFExceptionand that zero-progress skip is not retried.Validation
JAVA_HOME=/Users/cc/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home mvn -pl fluss-filesystems/fluss-fs-hadoop -am -Dtest=HadoopDataInputStreamTest#testSeekPastEndOfStreamThrowsEOFException -DfailIfNoTests=false testJAVA_HOME=/Users/cc/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home mvn -pl fluss-filesystems/fluss-fs-hadoop -am -Dtest=HadoopDataInputStreamTest -DfailIfNoTests=false testJAVA_HOME=/Users/cc/Library/Java/JavaVirtualMachines/corretto-18.0.2/Contents/Home mvn -pl fluss-filesystems/fluss-fs-hadoop -am -DfailIfNoTests=false testgit diff --check upstream/main...HEAD