[server] release remote log index cache entries on deletion#3737
Open
zuston wants to merge 1 commit into
Open
Conversation
Member
Author
|
ptal @fresh-borzoni |
fresh-borzoni
left a comment
fresh-borzoni
left a comment
Member
There was a problem hiding this comment.
@zuston Thank you, this is a very good addition 👍 Left suggestion, PTAL
| if (success) { | ||
| if (!expiredRemoteLogSegments.isEmpty()) { | ||
| // Release the mmap-backed local indexes before deleting the remote files. | ||
| remoteLogIndexCache.removeAll( |
Member
There was a problem hiding this comment.
Q: shall we removeAll after deleteRemoteLogSegmentFiles instead of before?
In the gap between manifest commit and remote deletion, an in-flight reader can miss the cache and re-download the index (remote files still exist at that point), re-inserting an entry that nothing will ever remove again, essentially the exact leak this PR fixes.
The read-refcount TODO would fix the reader-error half of this race, but not the leak half and the reorder(the thing that I propose here) composes with it if it ever lands: drain -> delete files -> removeAll.
WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Explicitly release remote log index cache entries on deletion.
Brief change log
Tests
API and Format
Documentation