Skip to content

[lake] Fix DvTableReadableSnapshotRetriever scanning wrong snapshot #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luoyuxia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[lake] Fix DvTableReadableSnapshotRetriever scanning wrong snapshot #3396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions ...on/src/main/java/org/apache/fluss/lake/paimon/utils/DvTableReadableSnapshotRetriever.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
import org.apache.fluss.utils.ExceptionUtils;
import org.apache.fluss.utils.types.Tuple2;

import org.apache.paimon.CoreOptions;
import org.apache.paimon.Snapshot;
import org.apache.paimon.data.BinaryRow;
import org.apache.paimon.data.BinaryString;
Expand Down Expand Up @@ -495,16 +494,10 @@ private LakeSnapshot getOrFetchLakeSnapshot(long snapshotId, Map<Long, LakeSnaps
Set<PaimonPartitionBucket> bucketsWithoutL0 = new HashSet<>();
Set<PaimonPartitionBucket> bucketsWithL0 = new HashSet<>();

// Scan the snapshot to get all splits including level0
Map<String, String> scanOptions = new HashMap<>();
scanOptions.put(CoreOptions.SCAN_SNAPSHOT_ID.key(), String.valueOf(snapshot.id()));
// hacky: set batch scan mode to compact to make sure we can get l0 level files
scanOptions.put(
CoreOptions.BATCH_SCAN_MODE.key(), CoreOptions.BatchScanMode.COMPACT.getValue());

// Scan the snapshot to get all data files including L0 level files
Map<BinaryRow, Map<Integer, List<ManifestEntry>>> manifestsByBucket =
FileStoreScan.Plan.groupByPartFiles(
fileStoreTable.copy(scanOptions).store().newScan().plan().files());
fileStoreTable.store().newScan().withSnapshot(snapshot).plan().files());

for (Map.Entry<BinaryRow, Map<Integer, List<ManifestEntry>>> manifestsByBucketEntry :
manifestsByBucket.entrySet()) {
Expand Down
Loading