[helm][hotfix] Go template whitespace trimming caused exceptions#2893
Open
morazow wants to merge 1 commit intoapache:mainfrom
Open
[helm][hotfix] Go template whitespace trimming caused exceptions#2893morazow wants to merge 1 commit intoapache:mainfrom
morazow wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close NA
In
secret-jaas-config.yaml, the variable assignments between the license comment block andapiVersionuse Go templating whitespace trimming({{- ... -}})approach.Since assignments produce no output, they consume all surrounding whitespaces, including the newline after the last
#comment line. This glues#andapiVersion: v1into#apiVersion: v1, which YAML parses as a comment.The resulting document has no
apiVersionfield, causing Helm to reject it with "apiVersion not set."The same issue also affects
serviceaccount.yaml, where the license block sits outside the{{- if .Values.serviceAccount.create }}guard, producing a comment-only YAML document when disabled.Brief change log
Move the variable assignments before the license block so the comment to apiVersion gap is no longer merged by trimming directives.
Tests
Existing tests pass
API and Format
NA
Documentation
NA