[flink] Allow partial updates for AGGREGATION merge engine#2888
Open
platinumhamburg wants to merge 1 commit intoapache:mainfrom
Open
[flink] Allow partial updates for AGGREGATION merge engine#2888platinumhamburg wants to merge 1 commit intoapache:mainfrom
platinumhamburg wants to merge 1 commit intoapache:mainfrom
Conversation
platinumhamburg
force-pushed
the
fix/aggregation-partial-update
branch
from
e2ba86e to
f34e240
Compare
The connector-side validation in FlinkTableSink.getSinkRuntimeProvider() was rejecting partial updates for ALL merge engines (mergeEngineType != null), but the server-side AggregateRowMerger fully supports partial updates via PartialAggregateRowMerger. Narrow the check to only block FIRST_ROW and VERSIONED engines which genuinely do not support partial updates. Add IT case for partial update on aggregation merge engine.
platinumhamburg
force-pushed
the
fix/aggregation-partial-update
branch
from
f34e240 to
1a941e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connector-side validation in FlinkTableSink.getSinkRuntimeProvider() was rejecting partial updates for ALL merge engines (mergeEngineType != null), but the server-side AggregateRowMerger fully supports partial updates via PartialAggregateRowMerger. Narrow the check to only block FIRST_ROW and VERSIONED engines which genuinely do not support partial updates.
Add IT case for partial update on aggregation merge engine.
Purpose
Linked issue: close #2887 2887
Brief change log
Tests
API and Format
Documentation