Skip to content

[Helm] Revert Chart Component Configuration Isolation (#2472) #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swuferhong merged 1 commit into from
Mar 13, 2026
+27 −47
Merged

[Helm] Revert Chart Component Configuration Isolation (#2472) #2863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions helm/templates/sts-coordinator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ metadata:
{{- include "fluss.labels" . | nindent 4 }}
spec:
serviceName: coordinator-server-hs
replicas: {{ .Values.coordinatorServer.replicas }}
replicas: {{ .Values.coordinator.numberOfReplicas }}
selector:
matchLabels:
{{- include "fluss.selectorLabels" . | nindent 6 }}
Expand Down Expand Up @@ -81,17 +81,17 @@ spec:

bin/coordinator-server.sh start-foreground
livenessProbe:
failureThreshold: {{ .Values.coordinatorServer.livenessProbe.failureThreshold }}
timeoutSeconds: {{ .Values.coordinatorServer.livenessProbe.timeoutSeconds }}
initialDelaySeconds: {{ .Values.coordinatorServer.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.coordinatorServer.livenessProbe.periodSeconds }}
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3
tcpSocket:
port: {{ .Values.listeners.client.port }}
readinessProbe:
failureThreshold: {{ .Values.coordinatorServer.readinessProbe.failureThreshold }}
timeoutSeconds: {{ .Values.coordinatorServer.readinessProbe.timeoutSeconds }}
initialDelaySeconds: {{ .Values.coordinatorServer.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.coordinatorServer.readinessProbe.periodSeconds }}
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3
tcpSocket:
port: {{ .Values.listeners.client.port }}
resources:
Expand Down
18 changes: 9 additions & 9 deletions helm/templates/sts-tablet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ metadata:
{{- include "fluss.labels" . | nindent 4 }}
spec:
serviceName: tablet-server-hs
replicas: {{ .Values.tabletServer.replicas }}
replicas: {{ .Values.tablet.numberOfReplicas }}
selector:
matchLabels:
{{- include "fluss.selectorLabels" . | nindent 6 }}
Expand Down Expand Up @@ -78,17 +78,17 @@ spec:

bin/tablet-server.sh start-foreground
livenessProbe:
failureThreshold: {{ .Values.tabletServer.livenessProbe.failureThreshold }}
timeoutSeconds: {{ .Values.tabletServer.livenessProbe.timeoutSeconds }}
initialDelaySeconds: {{ .Values.tabletServer.livenessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.tabletServer.livenessProbe.periodSeconds }}
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3
tcpSocket:
port: {{ .Values.listeners.client.port }}
readinessProbe:
failureThreshold: {{ .Values.tabletServer.readinessProbe.failureThreshold }}
timeoutSeconds: {{ .Values.tabletServer.readinessProbe.timeoutSeconds }}
initialDelaySeconds: {{ .Values.tabletServer.readinessProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.tabletServer.readinessProbe.periodSeconds }}
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3
tcpSocket:
port: {{ .Values.listeners.client.port }}
resources:
Expand Down
38 changes: 9 additions & 29 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,32 +27,6 @@ image:
pullPolicy: IfNotPresent
pullSecrets: []

coordinatorServer:
replicas: 1
livenessProbe:
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3
readinessProbe:
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3

tabletServer:
replicas: 3
livenessProbe:
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3
readinessProbe:
failureThreshold: 100
timeoutSeconds: 1
initialDelaySeconds: 10
periodSeconds: 3

# Fluss server configuration options
configurationOverrides:
default.bucket.number: 3
Expand All @@ -64,12 +38,14 @@ configurationOverrides:
internal.listener.name: INTERNAL

tablet:
numberOfReplicas: 3
storage:
enabled: false
size: 1Gi
storageClass:

coordinator:
numberOfReplicas: 1
storage:
enabled: false
size: 1Gi
Expand All @@ -82,15 +58,19 @@ listeners:
client:
port: 9124

resources:
coordinatorServer: {}
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# coordinatorServer:
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
tabletServer: {}
# tabletServer:
# requests:
# cpu: 100m
# memory: 128Mi
Expand Down