[server] Fix get table count of database.#2852
Open
loserwang1024 wants to merge 1 commit intoapache:mainfrom
Open
[server] Fix get table count of database.#2852loserwang1024 wants to merge 1 commit intoapache:mainfrom
loserwang1024 wants to merge 1 commit intoapache:mainfrom
Conversation
loserwang1024
force-pushed
the
fix-database-summbary
branch
2 times, most recently
from
75bd789 to
7ae61fc
Compare
loserwang1024
force-pushed
the
fix-database-summbary
branch
from
7ae61fc to
4073899
Compare
Member
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
wuchong
reviewed
Mar 16, 2026
| | `client.lookup.max-retries` | `2147483647` | Integer | Setting a value greater than zero will cause the client to resend any lookup request that fails with a potentially transient error. | | ||
| | `client.scanner.remote-log.prefetch-num` | `4` | Integer | The number of remote log segments to keep in local temp file for LogScanner, which download from remote storage. The default setting is 4. | | ||
| | `client.scanner.io.tmpdir` | `/var/folders/bp/v2l48kz51mx86d743qv0zhzh0000gn/T//fluss` | String | Local directory that is used by client for storing the data files (like kv snapshot, log segment files) to read temporarily | | ||
| | `client.scanner.io.tmpdir` | `/var/folders/qw/wkqk76752w15lm9xdq4q22s00000gp/T//fluss` | String | Local directory that is used by client for storing the data files (like kv snapshot, log segment files) to read temporarily | |
Comment on lines
+501
to
+507
| Map<String, String> tablesPathToDatabaseName = | ||
| databaseNames.stream() | ||
| .collect(toMap(TablesZNode::path, databaseName -> databaseName)); | ||
| List<ZkCheckExistsResponse> dbStatResponses = | ||
| getStatInBackground(dbPathToDatabaseName.keySet()); | ||
| List<ZkCheckExistsResponse> tablesStatResponses = | ||
| getStatInBackground(tablesPathToDatabaseName.keySet()); |
Member
There was a problem hiding this comment.
This change introduces double I/O overhead to the request. I suggest batching the stats retrieval operations to enable full parallelization, which will significantly reduce the total execution time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2851
Brief change log
Tests
API and Format
Documentation