[helm] Enable metrics reporting on helm charts#2711
Open
morazow wants to merge 1 commit intoapache:mainfrom
Open
[helm] Enable metrics reporting on helm charts#2711morazow wants to merge 1 commit intoapache:mainfrom
morazow wants to merge 1 commit intoapache:mainfrom
Conversation
morazow
force-pushed
the
mor-2677
branch
2 times, most recently
from
1f83844 to
c42ce9a
Compare
affo
reviewed
Mar 2, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
Amazing, thank you!
Some nits here in there, very punctual.
affo
suggested changes
Mar 6, 2026
morazow
force-pushed
the
mor-2677
branch
3 times, most recently
from
584c536 to
f91ef73
Compare
affo
reviewed
Mar 9, 2026
morazow
force-pushed
the
mor-2677
branch
2 times, most recently
from
5d8b718 to
706cd7e
Compare
affo
reviewed
Mar 11, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
Many comments were marked resolved even though they were not.
affo
reviewed
Mar 13, 2026
affo
reviewed
Mar 13, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
I suggested a design that favors the config overrides and treats every option independently to avoid generic implementations that may fire back to us
morazow
force-pushed
the
mor-2677
branch
2 times, most recently
from
ed064b6 to
1e6fee5
Compare
morazow
force-pushed
the
mor-2677
branch
2 times, most recently
from
843e257 to
f4cca17
Compare
affo
approved these changes
Mar 17, 2026
Contributor
affo
left a comment
affo
left a comment
There was a problem hiding this comment.
This is now damn good!
I think we are now having patterns that we can formalize better:
- forbid value in config override
- validate functions
I think we may have other follow-up PRs
Contributor
|
@swuferhong this should be ready now, can you give a look? |
--- Co-authored-by: Lorenzo Affetti <lorenzo.affetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2677
Adds support for setting up the metrics on Helm chart values.
Brief change log
Tests
Using helm unit tests
API and Format
NA
Documentation
Added usage docs to the Deploying with Helm documentation