[client] Throw Exception when retry several times when downloading log. - #1752
Merged
Merged
Conversation
Contributor
Author
|
@wuchong , CC |
loserwang1024
force-pushed
the
fix-dowload-deadlock
branch
2 times, most recently
from
March 3, 2026 09:09
a7076d3 to
21b2484
Compare
loserwang1024
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address issue #1751 (RemoteLogDownloader deadlock on download failures) by changing remote log download failure handling to retry a fixed number of times and then surface an exception to the client, plus plumbing failures through the fetch buffer/collector so the scanner can fail instead of stalling.
Changes:
- Add retry + exception propagation for remote log segment download failures.
- Propagate pending-fetch completion failures through
LogFetchBufferviaFetchException. - Add/extend unit tests covering fetch exception behavior in downloader/buffer/collector.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/RemoteLogDownloader.java |
Adds retry/error handling path for remote downloads (but currently has retry logic issues). |
fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/LogFetchBuffer.java |
Adds exception propagation via stored throwable and throws FetchException from peek/poll. |
fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/LogFetcher.java |
Updates collectFetch signature and (implicitly) relies on new exception propagation behavior. |
fluss-client/src/test/java/org/apache/fluss/client/table/scanner/log/RemoteLogDownloaderTest.java |
Adds test for downloader failure behavior (contains an unused variable). |
fluss-client/src/test/java/org/apache/fluss/client/table/scanner/log/LogFetchCollectorTest.java |
Adds test ensuring fetch exceptions propagate out of the collector. |
fluss-client/src/test/java/org/apache/fluss/client/table/scanner/log/LogFetchBufferTest.java |
Adds test ensuring buffer surfaces exceptions on peek/poll. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
loserwang1024
force-pushed
the
fix-dowload-deadlock
branch
2 times, most recently
from
March 3, 2026 11:50
a7f0c1a to
737b2a1
Compare
Contributor
Author
|
@wuchong , fix this test |
loserwang1024
force-pushed
the
fix-dowload-deadlock
branch
from
April 1, 2026 04:05
737b2a1 to
416c8e7
Compare
Contributor
Author
|
@wuchong , CC, it's important for me. |
2 tasks
loserwang1024
force-pushed
the
fix-dowload-deadlock
branch
from
June 12, 2026 08:44
416c8e7 to
0d91d8b
Compare
Contributor
Author
|
@swuferhong , I have rebased this PR, CC |
Co-Authored-By: Codex <noreply@openai.com> Co-Authored-By: Qoder <noreply@qoder.com> AI-Model: gpt-5.6-sol AI-Contributed/Feature: 124/127 AI-Contributed/UT: 224/224
loserwang1024
force-pushed
the
fix-dowload-deadlock
branch
from
September 16, 2026 08:49
0d91d8b to
168532a
Compare
Contributor
Author
|
@swuferhong , I have rebased this PR again |
swuferhong
reviewed
Sep 21, 2026
swuferhong
left a comment
swuferhong
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @loserwang1024, I have left some comments:
Co-Authored-By: Codex <noreply@openai.com> AI-Model: gpt-5.6-sol AI-Contributed/Feature: 59/59 AI-Contributed/UT: 54/54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #1751
Brief change log
Tests
API and Format
Documentation