[elixir] chore: Add dialyzer and tighten Fluss.Config setter guards#582
Open
nicolazar wants to merge 1 commit into
Open
[elixir] chore: Add dialyzer and tighten Fluss.Config setter guards#582nicolazar wants to merge 1 commit into
nicolazar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #575
Brief change log
This PR adds dialyzer and enforces it to pass in CI.
:dialyxiris added as a dev/test dep with PLT pinned topriv/plts/dialyzer.plt(so the CI cache key is predictable).We also add a new
mix checkalias to encapsulate all static checks in a single command for local verification.Finally, we tighten
Fluss.Confignumeric setter guards: they declarednon_neg_integer()typespecs, but guarded withis_integer/1— accepting negative values at runtime despite the spec.