chore: introduce SecurityTokenManager to update token in the background #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoyuxia
force-pushed
the
improve-creditial-cache
branch
from
a65eb61 to
935ef50
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces SecurityTokenManager to handle security token refreshes in a background task, replacing the synchronous CredentialsCache approach. This follows the pattern from the Java client, addressing issue #166 by moving credential fetching out of the fetch response handling path and into a dedicated background refresh loop.
Changes:
- Replaced
CredentialsCachewithSecurityTokenManagerthat runs a background task to periodically refresh security tokens based on expiration time - Modified
RemoteLogDownloaderto accept aCredentialsReceiver(watch channel) instead of requiring explicit credential updates viaset_remote_fs_props() - Updated
LogFetcherto create and start theSecurityTokenManageron initialization, subscribing to credential updates for the remote log downloader
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| crates/fluss/src/client/credentials.rs | Replaces CredentialsCache with SecurityTokenManager implementing a background token refresh loop using tokio watch channels for broadcasting updates |
| crates/fluss/src/client/table/scanner.rs | Updates LogFetcher to instantiate and start SecurityTokenManager, subscribing to credentials for RemoteLogDownloader; removes synchronous credential fetching from fetch response handling |
| crates/fluss/src/client/table/remote_log.rs | Modifies RemoteLogDownloader and ProductionFetcher to receive credentials via watch channel receiver; removes set_remote_fs_props() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@zhaohaidao Could you please help review when you got some time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #166
Brief change log
Tests
API and Format
Documentation