Repository navigation
[BP-2.4][FLINK-41448][table-planner] Name UDF metric groups after the normalized function name - #30057
Open
weiqingy wants to merge 1 commit into
Open
[BP-2.4][FLINK-41448][table-planner] Name UDF metric groups after the normalized function name#30057weiqingy wants to merge 1 commit into
weiqingy wants to merge 1 commit into
Conversation
Collaborator
Contributor
Author
|
@flinkbot run azure |
…zed function name Function names are case-insensitive in SQL, but the UDF metric group was named after BridgingSqlFunction#getName. For a temporary system function that is the spelling used at the call site, so calling one function as myUdf(x) and MYUDF(x) produced two groups, each with part of the samples. Use FunctionIdentifier#normalizeName for functions that are resolved by name, at both places that produce a UDF metric name, so every spelling reports under one lower-case group. An inline function is not resolved by name and keeps its generated, class-based name. Only the metric name changes; operator names and plans are unaffected.
weiqingy
force-pushed
the
FLINK-41448-bp-2.4
branch
from
November 21, 2026 05:55
685acac to
31de1fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Backport of #29910 to release-2.4. The UDF metric group (
udf.<udf_name>) is named after the normalized (lower-case) function name, so every spelling of a call reports under one group. Having this in 2.4.0 keeps the group names stable from the first release that has UDF metrics, so dashboards never need to change.Brief change log
Verifying this change
This change added tests in
UdfMetricsITCase.UdfMetricsITCase,AsyncCalcITCaseandAsyncCorrelateITCasepass on this branch.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code 2.1.329 (Claude Opus 5.5)