Skip to content

[BP-2.4][FLINK-41448][table-planner] Name UDF metric groups after the normalized function name - #30057

Open
weiqingy wants to merge 1 commit into
apache:release-2.4from
weiqingy:FLINK-41448-bp-2.4
Open

weiqingy wants to merge 1 commit into
apache:release-2.4from
weiqingy:FLINK-41448-bp-2.4

Conversation

@weiqingy

Copy link
Copy Markdown
Contributor

What is the purpose of the change

Backport of #29910 to release-2.4. The UDF metric group (udf.<udf_name>) is named after the normalized (lower-case) function name, so every spelling of a call reports under one group. Having this in 2.4.0 keeps the group names stable from the first release that has UDF metrics, so dashboards never need to change.

Brief change log

  • Cherry-pick of ddc060f, applied without conflicts

Verifying this change

This change added tests in UdfMetricsITCase. UdfMetricsITCase, AsyncCalcITCase and AsyncCorrelateITCase pass on this branch.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? docs

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code 2.1.329 (Claude Opus 5.5)

@flinkbot

flinkbot commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@weiqingy

Copy link
Copy Markdown
Contributor Author

@flinkbot run azure

…zed function name

Function names are case-insensitive in SQL, but the UDF metric group was
named after BridgingSqlFunction#getName. For a temporary system function
that is the spelling used at the call site, so calling one function as
myUdf(x) and MYUDF(x) produced two groups, each with part of the samples.

Use FunctionIdentifier#normalizeName for functions that are resolved by
name, at both places that produce a UDF metric name, so every spelling
reports under one lower-case group. An inline function is not resolved by
name and keeps its generated, class-based name. Only the metric name
changes; operator names and plans are unaffected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants