[FLINK-40478][runtime-web] Log effective HistoryServer configuration at startup - #29020
Open
argoyal2212 wants to merge 1 commit into
Open
Conversation
Adds storage type, load mode, and retention settings to the startup log.
Collaborator
Contributor
Contributor
Author
Thanks for taking a look @Jackeyzhe. I did not mean to have this as a followup rather keep it separate from #29008. Filed a new jira and linked this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Several HistoryServer configuration options change its runtime behavior in meaningful ways: which archive storage backend it uses (FILE vs ROCKSDB), the archive load mode (EAGER vs LAZY), and the retention policy (retained job/application counts, TTL, cleanup flags). None of these are logged today, they are just read into local variables and used silently.
This makes it hard to confirm from the logs what configuration actually took effect on a given HistoryServer instance. A misconfigured or overridden option can go unnoticed until something looks wrong in the UI, at which point the only way to check is to read the config file directly on the host or dig through source code.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as HistoryServerTest and HistoryServerArchiveFetcherTest, which continue to pass unmodified since no runtime behavior changes.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?