[hotfix][test] Use unique sink name in CascadedDeltaJoinITCase#28029
Open
snuyanzin wants to merge 2 commits intoapache:masterfrom
Open
[hotfix][test] Use unique sink name in CascadedDeltaJoinITCase#28029snuyanzin wants to merge 2 commits intoapache:masterfrom
CascadedDeltaJoinITCase#28029snuyanzin wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@xuyangzhong, @lincoln-lil since were are involved in #27828 |
Collaborator
Contributor
Author
|
here it is a link to GHA run on my fork https://github.com/snuyanzin/flink/actions/runs/24924498645 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
If tests are running in parallel they might reuse the same sink by name and sink will contain unexpected results
The idea is to use more unique sinks
examples of failure
https://github.com/apache/flink/actions/runs/24881538481/job/72892870040#step:12:10351
https://github.com/apache/flink/actions/runs/24895816554/job/72901841273#step:12:10351
https://github.com/apache/flink/actions/runs/24892915051/job/72897348906#step:12:10353
https://github.com/apache/flink/actions/runs/24904840364/job/72933022675#step:12:10352
Brief change log
it is test
Verifying this change
here it is a link to GHA run on my fork https://github.com/snuyanzin/flink/actions/runs/24924498645
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation
Was generative AI tooling used to co-author this PR?