[FLINK-33653][runtime] Introduce a benchmark for balanced tasks scheduling.#109
Open
RocMarshal wants to merge 5 commits into
Open
[FLINK-33653][runtime] Introduce a benchmark for balanced tasks scheduling.#109RocMarshal wants to merge 5 commits into
RocMarshal wants to merge 5 commits into
Conversation
RocMarshal
force-pushed
the
FLINK-33653
branch
2 times, most recently
from
9dadb61 to
db8caf0
Compare
RocMarshal
force-pushed
the
FLINK-33653
branch
2 times, most recently
from
ceabf1c to
8a86e29
Compare
RocMarshal
force-pushed
the
FLINK-33653
branch
from
8a86e29 to
0af97e9
Compare
Contributor
Author
|
Hi, @pnowojski Could you help take a look if you had the free time ? thank you ! |
… jobs with scheduler taskmanager load balance mode.
…ot sharing strategy.
…lot sharing resolver.
…lot request resolver.
…ot request matching.
RocMarshal
force-pushed
the
FLINK-33653
branch
from
0af97e9 to
8e064a5
Compare
mateczagany
suggested changes
May 17, 2026
| import org.apache.flink.runtime.jobmaster.slotpool.SimpleRequestSlotMatchingStrategy; | ||
| import org.apache.flink.runtime.jobmaster.slotpool.TasksBalancedRequestSlotMatchingStrategy; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.TestingSlot; | ||
| import org.apache.flink.runtime.scheduler.loading.DefaultLoadingWeight; |
There was a problem hiding this comment.
It has been renamed in https://github.com/apache/flink/pull/27333/changesgg so it probably should be:
import org.apache.flink.runtime.scheduler.taskexecload.DefaultTaskExecutionLoad;
| private SlotSharingResolverBenchmark benchmark; | ||
|
|
||
| public static void main(String[] args) throws RunnerException { | ||
| runBenchmark(SlotSharingResolverBenchmark.class); |
There was a problem hiding this comment.
This should pass SlotSharingResolverBenchmarkExecutor.class
| private InitSlotSharingStrategyBenchmark benchmark; | ||
|
|
||
| public static void main(String[] args) throws RunnerException { | ||
| runBenchmark(InitSlotSharingStrategyBenchmark.class); |
There was a problem hiding this comment.
This should pass InitSlotSharingStrategyBenchmarkExecutor.class
|
|
||
| @Setup(Level.Trial) | ||
| public void setup() throws Exception { | ||
| slotMatchingResolver = getSlotMatchingResolver(); |
There was a problem hiding this comment.
slotMatchingResolver gets assigned twice here
| } | ||
| } | ||
|
|
||
| public static ResourceProfile newGrainfinedResourceProfile(int slotIndex) { |
There was a problem hiding this comment.
Type: newfineGrainedResourceProfile
|
|
||
| private void configAdaptivePartitioner(StreamExecutionEnvironment env) { | ||
| Configuration config = new Configuration(); | ||
| config.set(TaskManagerOptions.TASK_MANAGER_LOAD_BALANCE_MODE, taskManagerLoadBalanceMode); |
There was a problem hiding this comment.
This will be set after the MiniCluster has already been created, and in my findings it will be ignored. Moving it to InputBenchmarkFlinkEnvironmentContext should solve this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.