Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the foundational member-application workflow for Nsimbi CBS while preserving Apache Fineract’s
m_clienttable as the canonical member record.The implementation adds a one-to-one application extension for managing member onboarding, review and approval before later integration with client activation, KYC and account-opening processes.
Changes
Added the
MemberApplicationdomain entity.Added
DIRECTandAGENCYapplication channels.Added the following workflow states:
DRAFTSUBMITTEDUNDER_REVIEWRETURNED_FOR_CORRECTIONAPPROVEDREJECTEDWITHDRAWNAdded a Spring Data repository with lookup by Fineract client ID.
Added member-application-specific domain exceptions.
Added optimistic locking to prevent conflicting updates.
Added Liquibase migration
0243.Registered migration
0243in the final tenant changelog.Added six member-application permissions.
Business Rules
The implementation enforces:
m_clientrecord.Database Changes
The migration creates
nsimbi_member_applicationwith:m_client.m_appuser.Agency-reference uniqueness is intentionally deferred until the originating agency identity and composite idempotency rules are defined.
Permissions
CREATE_MEMBER_APPLICATIONSUBMIT_MEMBER_APPLICATIONREVIEW_MEMBER_APPLICATIONAPPROVE_MEMBER_APPLICATIONREJECT_MEMBER_APPLICATIONWITHDRAW_MEMBER_APPLICATIONVerification
git diff --checkpassed.spotlessMiscCheckpassed as the available XML and miscellaneous formatting check.The exact original test command encountered a Swagger scanner heap failure during the resolve task. The focused tests passed using the same JVM memory limit while excluding
:fineract-provider:resolve.Module-wide
spotlessJavaCheckremains affected by seven inherited formatting violations in user-role and security files that were not modified by this PR.Deferred Work
This foundation PR does not implement:
Migration
0243has not yet been executed against a live supported database and must be verified before this work is merged into the final development branch.Branch Information
feat/user-role-administrationfeat/member-module-foundationf58d716bf1