Skip to content

FINERACT-2840: Detect CI via GITHUB_ACTIONS for Develocity build scans - #6461

Open
clayburn wants to merge 1 commit into
apache:developfrom
clayburn:develocity-ci-detection
Open

clayburn wants to merge 1 commit into
apache:developfrom
clayburn:develocity-ci-detection

Conversation

@clayburn

Copy link
Copy Markdown
Contributor

Description

Resolves FINERACT-2840.

settings.gradle derived isCI from the JENKINS_URL environment variable. Fineract's CI runs entirely on GitHub Actions, which never sets JENKINS_URL, and there is no Jenkins configuration anywhere in the repository — so isCI was always false.

Its only consumer is buildScan.uploadInBackground = !isCI, which meant background upload stayed enabled on CI. On an ephemeral GitHub Actions runner the job can terminate before a backgrounded Build Scan upload completes, losing the scan.

This keys the check to GITHUB_ACTIONS, which GitHub Actions always sets. Build Scan uploads are now synchronous on CI, and remain backgrounded for local developer builds where the added latency would be noticeable.

Also updates the Develocity Gradle plugin from 4.5.0 to 4.5.1.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

isCI was derived from JENKINS_URL, which GitHub Actions never sets, so it
was always false and uploadInBackground stayed enabled on CI. Background
upload on an ephemeral runner can lose a Build Scan when the job ends
before the upload completes. Key the check to GITHUB_ACTIONS instead.

Also update the Develocity Gradle plugin from 4.5.0 to 4.5.1. The Common
Custom User Data Gradle plugin is already on the latest version, 2.8.0.

Assisted-By: claude-code-opus-5
@Aman-Mittal

Copy link
Copy Markdown
Member

Fineract Signed Commits Check / Verify Commit Signatures (pull_request) I think we can ignore this as it is commit is already signed

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants