Skip to content

FINERACT-2836: Isolate Due Savings Charge Failures - #6460

Open
rhopman wants to merge 1 commit into
apache:developfrom
symbaglobal:FINERACT-2836-isolate-due-savings-charge-failures
Open

rhopman wants to merge 1 commit into
apache:developfrom
symbaglobal:FINERACT-2836-isolate-due-savings-charge-failures

Conversation

@rhopman

@rhopman rhopman commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

The Pay Due Savings Charges job previously processed all due charges in one shared transaction. If one account had insufficient funds, the job failed and rolled back successful charge collections for unrelated funded accounts.

This change processes each due savings charge in an independent transaction. Successful collections remain committed while failures are recorded with charge and account context, and the job continues processing the remaining charges before reporting the overall failure.

Tests cover mixed funded and insufficient-balance accounts, successful balance and charge updates, failure isolation, all-success behavior, and prevention of duplicate collection on rerun.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.
  • If merging this PR resolves a JIRA issue, I will mark that issue as resolved and set "Fix Version/s" appropriately.
  • I followed the AI Policy.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant